Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional port specification for GPIO #16

Merged
merged 5 commits into from
Aug 13, 2015
Merged

Conversation

bnhwa
Copy link
Collaborator

@bnhwa bnhwa commented Aug 12, 2015

Related to item 1 in #11.

pull request for port argument

"-p",
"--port",
type=int,
default=27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a help string explaining what this argument is used for and add a default value.

@jakirkham
Copy link
Member

Could you try making Trigger's constructor not take a default argument.

@jakirkham jakirkham changed the title Optarg Optional port specification for GPIO Aug 12, 2015
jakirkham added a commit that referenced this pull request Aug 13, 2015
Optional port specification for GPIO
@jakirkham jakirkham merged commit 79df941 into DudLab:master Aug 13, 2015
@jakirkham
Copy link
Member

Thanks @bnhwa.

@bnhwa bnhwa deleted the optarg branch August 13, 2015 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants